fix(youtube): respect active SABR tracks on cold start#80
Open
Priveetee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of InfinityLoop1308/PipePipe#2575
Pairs with the client-side lockscreen/background fix: InfinityLoop1308/PipePipeClient#70
Summary
While testing the Android 17 lockscreen issue, I found one SABR-side problem in the background/audio-only path.
Follow-up SABR requests already respected the active track state, but the first media request still behaved like audio + video were selected. In background playback this can make the session start with the wrong shape.
This makes the cold-start request respect the active SABR track types too.
Changes
Validation
Tested with the paired client patch on Pixel 8 / Android 17:
Build:
./gradlew :extractor:compileJavagit diff --check