test(prose): correct a stale PR state and two issue/PR mislabels - #979
Conversation
Three factual errors in test prose, found while surveying #NNN citations under tests/ for #719: - test_http_unit.py:2356-2365 claimed PR #457 was "still-open" and that the SETTINGS round trip "remains unreachable until that lands". Both were stale: #457 merged 2026-09-18, the `httpv2-frame/SETTINGS` key no longer exists in `EXPECTED_FAILURES` (verified by importing it: 43 keys, only httpv2 key is PRIORITY), and the round trip itself passes (reproduced: `httpv2.roundtrip()` reports 'OK' for that case). Rewrote the paragraph: the round trip works; what still raises `KeyError: 'flags'` is a bare `SettingsFrame(...).pack()` with no enclosing packet (reproduced directly), which is an unsupported invocation, not a round-trip defect. Cited `FrameType.post_process` by name rather than the stale `httpv2.py:144` line number (the real raise is at `packet['flags'][name]`, confirmed by traceback). `GH-445` is left alone -- it is this repo's own issue shorthand, used throughout pcapkit/ and tests/, and #445 is in fact an issue. - test_base_class_contract.py:45 called #547 and #570 "issues"; both are pull requests. - test_const_str_payload_870_unit.py:12 called #869 a "GitHub issue"; it is a pull request. No behaviour or citation-style changes -- tests/** is exempt from the #719 PR-citation rule. Ran each file individually under pytest and plain unittest (all three use subTest): 6/6, 7/7, 60/60 passed both ways.
1a5944b to
adfd210
Compare
|
GOOD TO GO at It re-derived every claim in the rewritten paragraph from its own worktree rather than trusting the It settled the dropped-pointer question with evidence I did not have, and the answer is stronger Amend scope confirmed: 1 file, +8/−9, one paragraph; the other two files are byte-identical to round 1. One finding independent of this PR, which I reproduced myself and am filing separately. Those three
|
Please follow the guide below
make pylint,make mypy,make isort) — prose-only, no code touchedmake testpasses, and a test case covers the change — ran the three touched files individually under pytest and plain unittest (never the full suite); no behaviour changed, so no new coverage is neededdocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A, changelog centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingchore— anything elseDescription of your pull request and other information
Found while surveying
#NNNcitations undertests/for #719. Three factual errors in test prose, unrelated to the citation-style question itself (tests/**is exempt from that rule):tests/protocols/application/test_http_unit.py:2361called PR corekit: let a nested schema's field callbacks reach the enclosing schema #457 "still-open"; it merged on 2026-09-18. TheGH-445citation next to it is correct and left alone —GH-nnnis this repo's own established issue shorthand (used throughoutpcapkit/andtests/), and A nested schema cannot reach the enclosing packet's fields by name, so CGA Parameters raises KeyError: 'length' #445 is in fact an issue.tests/test_base_class_contract.py:45called feat(foundation): make subclass registration opt-in for Engine, Reassembly, TraceFlow and Dumper (#514) #547 and feat(protocols): opt-in code= registration with enum-type inference for Protocol/ProtocolBase #570 "issues"; both are pull requests.tests/const/test_const_str_payload_870_unit.py:12called fix(const,vendor): bring 8 bespoke registries onto EnumRegistry, stop them minting #869 a "GitHub issue"; it is a pull request.No behaviour change.