Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/const/test_const_str_payload_870_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
``str(Method.GET) == ''``, ``len(str(Method.GET)) == 0`` and, most visibly,
``Method.GET == 'GET'`` was :data:`False` for every one of the 40 declared
members. True on ``main`` at ``60b85e3a4`` (measured), and true since the class
was first written -- GitHub issue #869 fixed the same inconsistency for an
was first written -- GitHub pull request #869 fixed the same inconsistency for an
*unregistered* member's own str payload
(:meth:`~pcapkit.const.http.method.Method._unregistered_member` now calls the
base's :meth:`~pcapkit.corekit.enum.EnumRegistry._unregistered_member`, which
Expand Down
17 changes: 8 additions & 9 deletions tests/protocols/application/test_http_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -2354,15 +2354,14 @@ def test_settings_frame_settings_field_wraps_item_schema(self) -> None:
``SettingPair`` instance.

This is a unit-level check on the field wiring, not an end-to-end
``HTTPv2`` round trip: the SETTINGS frame's pack path still dies
earlier on ``KeyError: 'flags'``, raised by ``FrameType.post_process``
at ``schema/application/httpv2.py:144`` where it reaches the enclosing
header's ``flags`` field through a nested packet context that cannot
see it (GH-445, fixed by the still-open PR #457), so a real
``SettingsFrame.pack()``/``HTTPv2(...).make()`` round trip through this
field remains unreachable until that lands. The
``httpv2-frame/SETTINGS`` entry in ``EXPECTED_FAILURES`` records that
same ``KeyError: 'flags'``.
``HTTPv2`` round trip. The round trip itself now passes -- there is
no ``EXPECTED_FAILURES`` entry for ``httpv2-frame/SETTINGS``, and
the generator's own round trip for it reports ``OK``. What a round
trip never exercises is a bare ``SettingsFrame(...).pack()`` called
with no enclosing packet: that still raises ``KeyError: 'flags'``,
from ``FrameType.post_process``'s ``packet['flags'][name]`` lookup,
which has no ``flags`` to read without a real header above it. That
is an unsupported invocation, not a defect in the round trip.
"""
from pcapkit.corekit.fields.misc import SchemaField
from pcapkit.protocols.schema.application.httpv2 import SettingPair, SettingsFrame
Expand Down
2 changes: 1 addition & 1 deletion tests/test_base_class_contract.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

:class:`RegistrationGateTests` is a regression pin, not a new behaviour. Every
assertion in it already held before part (c), because parts (a) and (b)
(issues #547 and #570) made registration opt-in on a keyword. It is written down
(pull requests #547 and #570) made registration opt-in on a keyword. It is written down
because the ruling promotes it from an accident of where the hook happens to live
into the specification, and an unasserted specification is one refactor away from
being untrue. The property worth noticing is the last one: a library-style
Expand Down
Loading