Repository navigation
ir.cmd: put RubyGems' bindir on RUBYPATH, so ir -S <gem executable> finds its binstub - #20
Merged
Merged
Conversation
… finds its binstub The Windows twin of the ir.sh change in #18. RubyGems writes a gem's binstubs to Gem.bindir, which for IronRuby is the directory ir.exe itself is in (RbConfig's bindir). ir.cmd only put Src\StdLib\bin on RUBYPATH, so `ir.cmd -S <gem executable>` after `igem.cmd install <gem>` skipped the binstub RubyGems had just written and took whatever came first on PATH - a host Ruby's command of the same name, if there was one. The directory of ir.exe now comes after Src\StdLib\bin and before an existing RUBYPATH, the same order ir.sh uses.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 3
📒 Files selected for processing: 26
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: adding RubyGems' bindir to RUBYPATH so ir -S can find gem executable binstubs. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
CI builds libprism from prism's main branch, and since ruby/prism#4255 (attach_comments, merged 2026-10-12) every build job has failed in the smoke test with "Unknown prism node type: 0 (TypeError)" - master, #17, #18 and #19 alike. That change altered prism's serialization in two places without moving the serialization version off 1.9, so the version check in PrismLoader could not catch it: - the options blob has a new attach_comments byte after freeze. The blob IronRuby wrote was one byte short, so prism read the scope count from the wrong offset; - the serialized header has a comment-attachment list after the comments (node id, count, comment indices). PrismLoader read its count as the magic comment count and walked off from there. PrismParser.BuildOptionsData writes the byte (0: IronRuby never asks for attachments) and PrismLoader.Load skips the list. PrismLex only reads the token stream, which ends before the header, so it needs nothing. The rest of the revision comes along so that every piece names the same prism commit, as Src/Prism/README.md asks: - Src/Prism/Generated is regenerated from cd76b0d1's config.yml: SymbolNode#value_loc became the non-optional content_loc (the bridge reads neither), and a WORDS_SEP_IMPLICIT token was added after WORDS_SEP. Ripper looks tokens up by name and skips the ones it has no event for, which is what prism's own lex_compat does with this one. - Src/StdLib/ruby/4.0/prism is prism's lib/ at cd76b0d1, generated files included; prism.rb keeps IronRuby's backend branch. parse_result/comments.rb is gone upstream - attaching comments moved into libprism. - Src/StdLib/ironruby/prism/ironruby.rb follows ffi.rb: attach_comments is a known option and is dumped after freeze, and the *_file APIs take a Pathname (to_path / to_str) the way PrismSource.with_file now does. - release.yml's PRISM_REF and the README build instructions move to cd76b0d1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows twin of #18, which fixes the same thing in
ir.sh.RubyGems writes a gem's binstubs to
Gem.bindir, which for IronRuby is the directoryir.exeitself is in (RbConfig'sbindir,Src\Console\bin\<config>\<tfm>[\win-x64]).ir.cmdonly putSrc\StdLib\binonRUBYPATH, soir.cmd -S <gem executable>afterigem.cmd install <gem>skipped the binstub RubyGems had just written and took whatever came first onPATH.The directory of
ir.exenow comes afterSrc\StdLib\binand before an existingRUBYPATH, the same orderir.shuses after #18. On Windows RubyGems writes both<name>and<name>.batthere;-Sresolves<name>, the Ruby script.Tested: the new
RUBYPATHlines in isolation with anIR_BINpath containing spaces and parentheses (C:\Program Files (x86)\...), withRUBYPATHempty and with an existing value containing parentheses; both come out as expected.ir.cmdstill parses and reaches its "no build" message. Not tested end to end against a builtir.exe: no .NET SDK on the machine this was written on, so CI's Windows job is the real check. CI is currently red on every branch for an unrelated reason (prism main changed its serialization format); that is being fixed separately.Summary by CodeRabbit
ir.exedirectory is now included inRUBYPATH, helping the application locate related files.