🧹 Refactor DocxEmbedPreview component in DocxEmbed.tsx - #57
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🧹 Refactor
DocxEmbedPreviewinsrc/DocxEmbed.tsx🎯 What:
Extracted
copyRenderedPageshelper function anduseDocxEmbedSynccustom hook out ofDocxEmbedPreviewinsrc/DocxEmbed.tsx.💡 Why:
DocxEmbedPreviewwas overly long and handled multiple concerns (cloning rendered DOM pages, managing animation frame sync, mutation observer setup, and IME neutralizer lifecycle). Extracting the custom hook and helper function separates concerns, improves readability, and makes the component significantly more maintainable.✅ Verification:
npm run typecheck).npm test).npm run build).✨ Result:
Reduced
DocxEmbedPreviewcomplexity and size while preserving all existing rendering, IME neutralizer, and DOM mutation observer behavior.PR created automatically by Jules for task 9301678634094966434 started by @MarsLuay