Skip to content

🧹 Refactor DocxEmbedPreview component in DocxEmbed.tsx #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarsLuay merged 1 commit into from
Aug 25, 2026
Merged

🧹 Refactor DocxEmbedPreview component in DocxEmbed.tsx #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 46 additions & 31 deletions src/DocxEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,30 @@ function resolveDocxEmbed(app: App, linkPath: string, sourcePath: string) {
return file && file.extension.toLowerCase() === 'docx' ? file : null;
}

function DocxEmbedPreview({
file,
buffer,
hostEl,
i18n,
}: {
file: TFile;
buffer: ArrayBuffer;
hostEl: HTMLElement;
i18n: Translations | undefined;
}) {
function copyRenderedPages(pagesContainer: HTMLElement, pagesEl: HTMLElement, hostEl: HTMLElement) {
const pages = Array.from(pagesContainer.querySelectorAll<HTMLElement>(DOCX_RENDERED_PAGE_SELECTOR));
if (pages.length === 0) {
return;
}

pagesEl.empty();
for (const page of pages) {
pagesEl.appendChild(page.cloneNode(true));
}

const firstPage = pages[0];
if (!firstPage) {
return;
}

const pageRect = firstPage.getBoundingClientRect();
hostEl.setCssProps({
'--native-powerpoint-doc-editor-embed-page-height': `${Math.ceil(pageRect.height)}px`,
'--native-powerpoint-doc-editor-embed-page-width': `${Math.ceil(pageRect.width)}px`,
});
}

function useDocxEmbedSync(hostEl: HTMLElement) {
const sourceRef = useRef<HTMLDivElement>(null);
const pagesRef = useRef<HTMLDivElement>(null);
const renderedDomContextRef = useRef<RenderedDomContext | null>(null);
Expand All @@ -52,26 +65,7 @@ function DocxEmbedPreview({
return;
}

const pages = Array.from(renderedDomContext.pagesContainer.querySelectorAll<HTMLElement>(DOCX_RENDERED_PAGE_SELECTOR));
if (pages.length === 0) {
return;
}

pagesEl.empty();
for (const page of pages) {
pagesEl.appendChild(page.cloneNode(true));
}

const firstPage = pages[0];
if (!firstPage) {
return;
}

const pageRect = firstPage.getBoundingClientRect();
hostEl.setCssProps({
'--native-powerpoint-doc-editor-embed-page-height': `${Math.ceil(pageRect.height)}px`,
'--native-powerpoint-doc-editor-embed-page-width': `${Math.ceil(pageRect.width)}px`,
});
copyRenderedPages(renderedDomContext.pagesContainer, pagesEl, hostEl);
}, [hostEl]);

const queueSyncPages = useCallback(() => {
Expand Down Expand Up @@ -142,6 +136,27 @@ function DocxEmbedPreview({
};
}, [queueSyncPages]);

return {
pagesRef,
sourceRef,
queueSyncPages,
handleRenderedDomContextReady,
};
}

function DocxEmbedPreview({
file,
buffer,
hostEl,
i18n,
}: {
file: TFile;
buffer: ArrayBuffer;
hostEl: HTMLElement;
i18n: Translations | undefined;
}) {
const { pagesRef, sourceRef, queueSyncPages, handleRenderedDomContextReady } = useDocxEmbedSync(hostEl);

return (
<>
<div className="native-powerpoint-doc-editor-embed-viewport">
Expand Down