Skip to content

[release/1.6.x] build: preflight xkbcommon and document GLFW prerequisites - #1373

Closed
jiwenc-nv wants to merge 1 commit into
release/1.6.xfrom
jiwenc-nv/nvbugs-xkbcommon-release-1.6
Closed

jiwenc-nv wants to merge 1 commit into
release/1.6.xfrom
jiwenc-nv/nvbugs-xkbcommon-release-1.6

Conversation

@jiwenc-nv

Copy link
Copy Markdown
Collaborator

Description

Backport #1355 to release/1.6.x by cherry-picking 04476965710d81d9d7245af884289a90e71d56bf without changes.

Fresh Linux source builds can fail inside GLFW because libxkbcommon-dev is missing. Check xkbcommon>=0.5.0 in the shared Wayland preflight and report the installation command. Complete the GLFW prerequisites and link OAK, Wuji, LeRobot, and camera setup to the shared instructions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

  • Release CMake/pkg-config scenarios: installed, missing, too old, disabled backends, missing pkg-config, non-Linux, and retry after availability.
  • Top-level configure reports the missing dependency before fetching GLFW.
  • make -C docs current-docs, generated links, shell syntax, and SKIP=check-copyright-year pre-commit run --all-files passed.
  • Exercised the existing preflight directly; no new test suite. Hardware regressions remain for SQA.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Catch missing Wayland keyboard development files before fetching GLFW, and direct source-build entry points to complete shared prerequisites.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
(cherry picked from commit 0447696)
Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv

Copy link
Copy Markdown
Collaborator Author

dupe of #1379

@jiwenc-nv jiwenc-nv closed this Oct 28, 2026
auto-merge was automatically disabled October 28, 2026 16:07

Pull request was closed

github-actions Bot added a commit that referenced this pull request Oct 28, 2026

This branch was successfully deployed

1 active deployment
dev — 6f7f60f4 Deployed Oct 28, 2026 by jiwenc-nv via publish-wheel #6127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants