Skip to content

[Cherry-pick #1395] fix(webxr): prevent DevUI and controller pointer-ID collisions - #1396

Closed
yanziz-nvidia wants to merge 1 commit into
NVIDIA:release/1.6.xfrom
yanziz-nvidia:yanziz/cherry-pick-1395-release-1.6
Closed

yanziz-nvidia wants to merge 1 commit into
NVIDIA:release/1.6.xfrom
yanziz-nvidia:yanziz/cherry-pick-1395-release-1.6

Conversation

@yanziz-nvidia

Copy link
Copy Markdown
Collaborator

Backport #1395 to release/1.6.x to prevent DevUI mouse captures from colliding with XR controller pointer IDs. IWER and DevUI use the client's shared pointer-events module, with the emulator kept in its lazy bundle.

Cherry-picked fb60245e941b6c95bf13c1e06f0d8e1eecb9673f with -x; applied without conflicts and the patch ID matches the source commit.

Validation:

  • Clean npm install with normal peer checks.
  • All 11 WebXR Jest suites passed (120 tests).
  • Production webpack build passed (bundle-size/performance warnings).
  • SKIP=check-copyright-year pre-commit run --all-files passed.
  • git diff --check passed.

Interactive controller-gizmo taps and drags in a visible XR session were not repeated locally for this backport.

…A#1395)

* fix(webxr): upgrade IWER and DevUI to 2.7.0

Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>

* fix(webxr): share DevUI pointer IDs with the client

Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>

---------

Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>
(cherry picked from commit fb60245)
Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@yanziz-nvidia
yanziz-nvidia requested review from fvaloppi-nv, gareth-morgan-nv and jiwenc-nv and removed request for gareth-morgan-nv October 29, 2026 17:08
@yanziz-nvidia yanziz-nvidia self-assigned this Oct 29, 2026
@yanziz-nvidia
yanziz-nvidia deleted the yanziz/cherry-pick-1395-release-1.6 branch October 29, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants