Skip to content

Use underscore flags in EgoHand docker wrappers - #1400

Merged
shaosu-nvidia merged 1 commit into
mainfrom
ssx/egohand_docker
Oct 29, 2026
Merged

shaosu-nvidia merged 1 commit into
mainfrom
ssx/egohand_docker

Conversation

@shaosu-nvidia

@shaosu-nvidia shaosu-nvidia commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Rename the egohand_inference.sh and detector.sh options to snake_case so they match the host run_egohand_inference_pipeline.py and run_hand_detector.py flags (e.g. --intrinsics_json, --bbox_dir, --hand_detector_weight, --hf_token). Boolean --tracking/--no-tracking is unchanged. Update the docker README and cross-references.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Documentation
    • Updated Docker setup instructions, command examples, and mount-layout guidance to use underscore-separated option names.
  • Command-Line Interface
    • Docker scripts now use underscore-separated names for options such as --intrinsics_json, --bbox_dir, and --hf_token. Usage text and validation messages reflect the updated spellings; required arguments, accepted detector values, and validation rules are unchanged.

Rename the egohand_inference.sh and detector.sh options to snake_case so
they match the host run_egohand_inference_pipeline.py and
run_hand_detector.py flags (e.g. --intrinsics_json, --bbox_dir,
--hand_detector_weight, --hf_token). Boolean --tracking/--no-tracking is
unchanged. Update the docker README and cross-references.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Shao Su <shaoxiangs@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Walkthrough

The Docker inference scripts now accept underscore-separated option names, and their usage text, validation messages, comments, and README examples use the same spellings. The accepted detector values, required arguments, validation rules, and documented workflow behavior remain unchanged.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to 22f32

The Docker option spelling update is consistent and introduces no established runtime or workflow risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: replacing hyphenated flags with underscore-form flags in the EgoHand Docker wrappers.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

Finishing Touches: 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@shaosu-nvidia
shaosu-nvidia merged commit df84b3f into main Oct 29, 2026
62 of 87 checks passed
@shaosu-nvidia
shaosu-nvidia deleted the ssx/egohand_docker branch October 29, 2026 22:35

This branch was successfully deployed

1 active deployment
dev — 22f32daa Deployed Oct 29, 2026 by shaosu-nvidia via publish-wheel #6288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants