Repository navigation
Use underscore flags in EgoHand docker wrappers - #1400
Merged
Merged
Conversation
Rename the egohand_inference.sh and detector.sh options to snake_case so they match the host run_egohand_inference_pipeline.py and run_hand_detector.py flags (e.g. --intrinsics_json, --bbox_dir, --hand_detector_weight, --hf_token). Boolean --tracking/--no-tracking is unchanged. Update the docker README and cross-references. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Shao Su <shaoxiangs@nvidia.com>
Contributor
qingsi-at-nv
approved these changes
Oct 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the egohand_inference.sh and detector.sh options to snake_case so they match the host run_egohand_inference_pipeline.py and run_hand_detector.py flags (e.g. --intrinsics_json, --bbox_dir, --hand_detector_weight, --hf_token). Boolean --tracking/--no-tracking is unchanged. Update the docker README and cross-references.
Type of change
Testing
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCOSummary by CodeRabbit
--intrinsics_json,--bbox_dir, and--hf_token. Usage text and validation messages reflect the updated spellings; required arguments, accepted detector values, and validation rules are unchanged.