Add toggles for cmake unity build - #2052
Open
nullsystem wants to merge 1 commit into
Open
Conversation
nullsystem
marked this pull request as draft
August 5, 2026 17:15
nullsystem
force-pushed
the
CMakeUnityToggle
branch
from
August 5, 2026 17:27
979f214 to
0fb7783
Compare
One for client/server and one for vgui2/tier1/mathlib as may want to turn it off only for working on just client/server library side. Also fixup compile/linker errors since the changes and add NEO_UNITY defines to fixup for those ifdef changes. Add info in README.
nullsystem
force-pushed
the
CMakeUnityToggle
branch
from
August 5, 2026 17:30
0fb7783 to
6d33c0e
Compare
nullsystem
marked this pull request as ready for review
August 5, 2026 17:31
Rainyan
approved these changes
Aug 5, 2026
Rainyan
left a comment
Rainyan
left a comment
Member
There was a problem hiding this comment.
LGTM, tested on Win11 with MSVC 2022 and toggling the new options in CMakeLists.txt and then running "Project" -> "Delete Cache and Reconfigure" and "Build" -> "Rebuild All" to force the non-unity rebuild.
AdamTadeusz
approved these changes
Aug 6, 2026
| ConVar mat_tonemap_percent_bright_pixels( "mat_tonemap_percent_bright_pixels", "2.0", FCVAR_CHEAT ); | ||
| ConVar mat_tonemap_min_avglum( "mat_tonemap_min_avglum", "3.0", FCVAR_CHEAT ); | ||
| #ifdef NEO // Unity build | ||
| #ifdef NEO_UNITY // Unity build |
Contributor
There was a problem hiding this comment.
Is this comment still needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One for client/server and one for vgui2/tier1/mathlib as may want to turn it off only for working on just client/server library side. Also fixup compile/linker errors since the changes and add NEO_UNITY defines to fixup for those ifdef changes.
Toolchain
Linked Issues