Repository navigation
[18.0][FIX] spreadsheet_oca: compute filename per record - #136
Merged
OCA-git-bot merged 1 commit intoOct 20, 2026
Merged
Conversation
pedrobaeza
requested changes
Oct 20, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Please check https://github.com/pypa/pip/blob/main/AI_POLICY.md and remove the test that is not adding real value.
_compute_filename read self.name inside the loop, so computing the field on more than one record at once (list views, exports, batch reads) raised "ValueError: Expected singleton".
chichi0718
force-pushed
the
18.0-fix-spreadsheet_oca-filename
branch
from
October 20, 2026 15:47
3448f2a to
fe6e0ef
Compare
pedrobaeza
approved these changes
Oct 20, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Thanks for the changes. Let's fast-track this, as obvious patch.
/ocabot merge patch
Please fw-port it to 19 if applicable.
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at b7884e8. Thanks a lot for contributing to OCA. ❤️ |
Contributor
Author
|
Thanks! Forward-port to 19.0: #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_compute_filenamereadsself.nameinsidefor record in self, so computingfilenameon more than one record at once (list views, exports, batchread()) raises:This PR uses
record.name.The same one-line fix is also part of the larger feature PR #99; it is extracted here so the bug fix can land independently of that review.