Repository navigation
[19.0][FW] spreadsheet_oca: compute filename per record - #139
Merged
OCA-git-bot merged 1 commit intoOct 21, 2026
Merged
Conversation
_compute_filename read self.name inside the loop, so computing the field on more than one record at once (list views, exports, batch reads) raised "ValueError: Expected singleton".
pedrobaeza
approved these changes
Oct 21, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Fast-tracking as well as clear bug:
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 08d8efc. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #136. Replaces #138, which got closed when I deleted my fork by mistake.
_compute_filenamereadsself.nameinsidefor record in self, so computingfilenameon more than one record at once (list views, exports, batchread()) raisesValueError: Expected singleton. This PR usesrecord.name.