Skip to content

fix(client-python)!: properly moving once and for all to py3.14 (#353) - #356

Draft
Ferdinand (guzmud) wants to merge 2 commits into
mainfrom
fix/353-align-on-py314
Draft

fix(client-python)!: properly moving once and for all to py3.14 (#353)#356
Ferdinand (guzmud) wants to merge 2 commits into
mainfrom
fix/353-align-on-py314

Conversation

@guzmud

@guzmud Ferdinand (guzmud) commented Oct 8, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Properly aligning everything on python 3.14

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI balanced review requested due to automatic review settings October 8, 2026 07:16
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Oct 8, 2026
Copilot AI reviewed Oct 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The unchanged Read the Docs configuration still uses Python 3.12 and can no longer install the package.

1 open finding
What changed in this PR

Aligns the package and primary CI workflows with Python 3.14.

Changes:

  • Raises the package’s minimum Python version to 3.14.
  • Updates CircleCI formatting, testing, build, and deployment images.
  • Updates coverage and release workflows to Python 3.14.
File Description
pyproject.toml Requires Python 3.14 or newer.
.circleci/​config.yml Uses Python 3.14 images.
.github/​workflows/​coverage.yml Runs coverage under Python 3.14.
.github/​workflows/​release.yml Runs releases under Python 3.14.

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread pyproject.toml Resolved
@guzmud Ferdinand (guzmud) added the do not merge Do not merge until this label is removed. label Oct 15, 2026
@guzmud

Ferdinand (guzmud) commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

While the codebase is already compatible with 3.14, some elements (such as the prowler injector) are not ready to be 3.14-minimum, hence the do not merge.

Split Python environments can be used for conflicting cases such as prowler (cf OpenAEV-Platform/injectors#468 with the installation of py3.12 inside a py3.14 image).

@guzmud Ferdinand (guzmud) removed the do not merge Do not merge until this label is removed. label Oct 15, 2026
mariot
Mariot Tsitoara (mariot) reviewed Oct 21, 2026
View reviewed changes
Comment thread pyproject.toml
license = { text = "Apache-2.0" }
readme = "README.md"
requires-python = ">=3.11"
requires-python = ">=3.14"

@mariot Mariot Tsitoara (mariot) Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it assumed that we won't support versions before 3.14 anymore? My assumption was to make it work with 3.14, not than it should only work with 3.14+

@guzmud Ferdinand (guzmud) Oct 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client is already py3.14 compatible (afaik), so this PR is to enforce it indeed. Do you think it's the wrong call to make?

@mariot Mariot Tsitoara (mariot) Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we have the ability to support multiple python versions, we should do it. Right now it work from 3.11 to 3.14. Capping it at 3.14 seems like a waste. And will force many people to upgrade their versions.

@guzmud Ferdinand (guzmud) Oct 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the related issue is now paused. Thank you for your review!

@guzmud Ferdinand (guzmud) added the do not merge Do not merge until this label is removed. label Oct 23, 2026
@guzmud
Ferdinand (guzmud) marked this pull request as draft October 23, 2026 07:02
@guzmud Ferdinand (guzmud) changed the title fix(client-python): properly moving once and for all to py3.14 (#353) fix(client-python)!: properly moving once and for all to py3.14 (#353) Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariot Mariot Tsitoara (mariot) mariot left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do not merge Do not merge until this label is removed. filigran team Item from the Filigran team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ci(client-python): harmonize python versions in CI files

3 participants

@guzmud @mariot