Skip to content

fix(client-python)!: properly moving once and for all to py3.14 (#353) #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Ferdinand (guzmud) wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(client-python)!: properly moving once and for all to py3.14 (#353) #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b9092
fix(client-python): properly moving once and for all to py3.14 (#353)
guzmud Oct 8, 2026
fd2c3f8
doc(client-python): adding the missing logo
guzmud Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ orbs:
jobs:
ensure_formatting:
docker:
- image: cimg/python:3.13
- image: cimg/python:3.14
working_directory: ~/repo
steps:
- checkout
Expand All @@ -27,7 +27,7 @@ jobs:
template: basic_fail_1
test:
docker:
- image: cimg/python:3.13
- image: cimg/python:3.14
working_directory: ~/repo
steps:
- checkout
Expand All @@ -54,7 +54,7 @@ jobs:
build:
working_directory: ~/openaev-client
docker:
- image: cimg/python:3.13
- image: cimg/python:3.14
steps:
- checkout
- run:
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
deploy:
working_directory: ~/openaev-client
docker:
- image: cimg/python:3.13
- image: cimg/python:3.14
steps:
- checkout
- attach_workspace:
Expand Down
Binary file added .github/img/logo_filigran.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup uv
uses: astral-sh/setup-uv@v8.1.0
with:
python-version: "3.12"
python-version: "3.14"

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v6
with:
python-version: 3.11
python-version: 3.14
- name: Install dependencies
run: |
git config --global url."https://x-access-token:${GH_TOKEN}@github.com".insteadOf https://github.com
Expand All @@ -46,4 +46,4 @@ jobs:
GH_TOKEN: ${{ secrets.RELEASE_TOKEN }}
- name: execute py script # run file
run: |
python scripts/release.py ${{ inputs.branch_client_python }} ${{ inputs.previous_version }} ${{ inputs.new_version }} ${{ secrets.RELEASE_TOKEN }}
python scripts/release.py ${{ inputs.branch_client_python }} ${{ inputs.previous_version }} ${{ inputs.new_version }} ${{ secrets.RELEASE_TOKEN }}
2 changes: 1 addition & 1 deletion .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 2
build:
os: ubuntu-22.04
tools:
python: "3.12"
python: "3.14"

sphinx:
configuration: docs/conf.py
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ maintainers = [
]
license = { text = "Apache-2.0" }
readme = "README.md"
requires-python = ">=3.11"
requires-python = ">=3.14"
Comment thread
guzmud marked this conversation as resolved.
Resolved

@mariot Mariot Tsitoara (mariot) Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it assumed that we won't support versions before 3.14 anymore? My assumption was to make it work with 3.14, not than it should only work with 3.14+

@guzmud Ferdinand (guzmud) Oct 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client is already py3.14 compatible (afaik), so this PR is to enforce it indeed. Do you think it's the wrong call to make?

@mariot Mariot Tsitoara (mariot) Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we have the ability to support multiple python versions, we should do it. Right now it work from 3.11 to 3.14. Capping it at 3.14 seems like a waste. And will force many people to upgrade their versions.

@guzmud Ferdinand (guzmud) Oct 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the related issue is now paused. Thank you for your review!

classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
Expand Down
Loading