Repository navigation
fix(syft-job): sort submission files by posix path for Windows - #9596
Merged
Merged
Conversation
WindowsPath sorts case-insensitively and PosixPath case-sensitively, so a DS on Windows and a DO on Linux hashed files in a different order. The CRLF part of this PR is no longer needed since #9593 sends job files byte for byte. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
koenvanderveen
enabled auto-merge
October 29, 2026 10:16
koenvanderveen
disabled auto-merge
October 29, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowsPath sorts case-insensitively and PosixPath case-sensitively, so a DS on Windows and a DO on Linux fed files into the submission hash in a different order and the hashes did not match.
_digestnow sorts on the relative posix path.Taken from #9584 by @nethantd. The CRLF part of that PR was dropped, since #9593 sends job files byte for byte and both sides hash raw bytes.
Part of #9551.
🤖 Generated with Claude Code