Repository navigation
Engine 0.183.368 candidate: typed External Service CREATE TCP health checks - #156
Merged
Merged
Conversation
chen21019
marked this pull request as ready for review
November 4, 2026 20:39
chen21019
deleted the
feature/engine368-external-tcp-candidate-20261105
branch
November 4, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Service CREATE gains an optional closed TCP healthCheck with required port (1..65535) and optional interval, responseTimeout, healthyThreshold and unhealthyThreshold. The timing fields use the existing typed positive-integer subset (1..2147483647); omitted values are not filled. HTTP controls, unknown fields, nulls, wrong types and fractions are rejected. The detached native body alone selects TCP with requestLine=null; human review retains the exact caller fields, and verified creation requires matching native readback. Omitting healthCheck preserves None; External UPDATE and ordinary Service behavior are unchanged.
Current parent/owner/role/Key/revision, normal approval, native preflight and durable one-claim checks remain. C03 re-extraction preserves 447 inputs and all 1396 HTTP tuples, with no operation, admission, schema or role-grant delta. The required-method registry retains all 125 identities and adds the exact seven TCP methods (132 total).
Version preparation changes 89 POMs and four existing version scripts to 0.183.368. README remains on published367; the new release note and compatibility entry explicitly describe an unpublished candidate. Existing focused source evidence covers 48 unique methods (7 new, 41 inherited) and was carried without a local rerun. Necessary original CI and exact Surefire XML coverage are pending. No artifact qualification, publication, deployment or runtime PASS is claimed.