chore: consolidate kinova content out of example_ws

[nbbrooks]

Issue PickNikRobotics/moveit_pro#18874 consolidates the Kinova/Kortex configurations into a dedicated workspace at
https://github.com/PickNikRobotics/moveit_pro_kinova_ws. The Kinova hardware-side configs and the kinova_sim boilerplate move out of this example workspace. The two satellite demo configs are world/example content (not Kinova boilerplate) and stay here, but they no longer inherit from the now-deleted kinova_sim.

Removed

• src/moveit_pro_kinova_configs/kinova_gen3_base_config
• src/moveit_pro_kinova_configs/kinova_gen3_site_config
• src/moveit_pro_kinova_configs/kinova_sim
• src/moveit_pro_kinova_configs/moveit_studio_kinova_pstop_manager
• The moveit_pro_kinova_configs/ metapackage directory (empty after the moves below)
• ros2_kortex_vision submodule (only ever used by the kinova_vision wrist-camera driver, which lived with the hardware configs)

ros2_kortex stays — space_satellite_sim still pulls kortex_description for the arm URDF.

Moved

The satellite demo packages move out of the now-empty kinova_configs metapackage to top-level src/, matching how the other example worlds (lab_sim, factory_sim, hangar_sim, ...) are laid out:

• src/moveit_pro_kinova_configs/space_satellite_sim -> src/space_satellite_sim
• src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal -> src/space_satellite_sim_camera_cal

Flattened

space_satellite_sim previously had based_on_package: kinova_sim, so it inherited the URDF/SRDF launch, MoveIt configuration, ros2_control config, ros_global_params, and various YAMLs from kinova_sim. With kinova_sim deleted there is nothing to inherit from, and per project guidance the satellite demos shouldn't inherit from the Kinova boilerplate anyway (an example of how someone modifies the boilerplate, not a config that inherits from it).

• Dropped based_on_package: kinova_sim from space_satellite_sim's config.yaml; inlined the hardware, ros_global_params, moveit_params, and ros2_control sections it had been inheriting. All package paths rewritten from "kinova_sim" -> "space_satellite_sim".
• Copied the previously-referenced helper YAMLs from kinova_sim into space_satellite_sim/config/{moveit,control}/ so they ship with the demo: pose_ik_distance.yaml sensors_3d.yaml joint_limits.yaml pose_jog.yaml joint_jog.yaml picknik_kinova_gen3.ros2_control.yaml Pre-existing copies in space_satellite_sim (e.g. its own space_satellite_sim.srdf) were preserved.
• Dropped the now-unused robot_driver_persist_launch_file field (kinova_sim's value pointed at a launch file that didn't exist in kinova_sim/launch/ anyway, so dropping it doesn't change runtime behavior). MoveIt Pro defaults to a blank launch when not specified.
• space_satellite_sim/package.xml drops the kinova_sim and moveit_studio_kinova_pstop_manager exec_depends. The remaining deps (kortex_description, picknik_mujoco_ros, picknik_accessories, realsense2_description, robotiq_description, apriltag_ros, joint_trajectory_admittance_controller, velocity_force_controller) are what the demo's URDF and Objectives actually consume.

space_satellite_sim_camera_cal still uses
based_on_package: space_satellite_sim. That is intra-example inheritance (the calibration variant of the same demo), which the doc explicitly recommends for "small variations" — keeping it.

README

Top-level README's robot-config list drops the moveit_pro_kinova_configs/* entries and adds the satellite configs at top level.

[davetcoleman]

[written by AI]

Stale PR sweep. Opened 2026-05-12, last commit 2026-05-12. We are cleaning up open PRs older than three months.

State: never executed. src/moveit_pro_kinova_configs/ is still fully present on main, so the consolidation this performs (roughly 11,000 deleted lines across 433 files) has not happened. Its sibling in moveit_pro, #18998, which updates the documentation links to point after the move, is also still open and blocked on this.

Recommendation: decide #18874 once, for both PRs. A 433 file deletion is the single most rebase-hostile PR in either repo, so if the consolidation is still the plan it should land now. If it is not, close this and #18998 together and drop the issue.

@nbbrooks is moving the Kinova content out of example_ws still the intent?