Conversation
This was referenced Oct 1, 2026
mmiermans
force-pushed
the
mmiermans/HNT-3494-upload-test
branch
from
October 1, 2026 19:16
787f258 to
e91b53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add test coverage for file uploads through admin-api before the Apollo Server 5 upgrade. A broken upload path currently fails silently: the subgraph receives a null file and still returns HTTP 200.
src/server/upload.spec.tssends a multipart request through the real express app and gateway (FileUploadDataSource) to a stub subgraph. The stub parses the request withgraphql-upload, the same way curated-corpus-api does.__proto__andconstructor.prototypeupload paths go through the upload data source without pollutingObject.prototype. This covers profusion's unpatchedlodash.set, which arrives with the AS5 upgrade.getAppGateway(overrides)lets the test inject a locally composed supergraph.Implementation Decisions
FileUploadDataSourceis swapped for a plainRemoteGraphQLDataSource.graphql+graphql-uploadrather than Apollo Server, so the test survives the AS5 upgrade unchanged.Deployment steps
References
JIRA ticket:
Stacked on #389.