Repository navigation
Port the template catch-up and dynamic classifiers from main to 5.0.x - #14
Merged
Merged
Conversation
…_testing, shared workflows, AGENTS.md Remove the copies of the workflows (Test.yml, Testbase.yml, updater.yml) and call the reusable ones of pymodaq_plugins_template; add AGENTS.md and CLAUDE.md for AI coding assistants. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
pymodaq>=5.3.2, pymodaq_utils>=5.3.1, pymodaq_gui>=5.3.0, pymodaq_data>=5.3.0, so that the acceptance tests and the rest of this change are met at install time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Move the static classifiers to [tool.pymodaq], declare classifiers as dynamic and require pymodaq_utils>=5.3.6 to build. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
5.0.x(the NIDAQmx rewrite) has the old per-repository workflows, no acceptance test,pymodaq>=5.0as the only floor, and static classifiers.mainalready got those changes (#11, #13).After: the same three commits applied on
5.0.x: shared workflows of the plugin template,tests/test_plugin_package_structure.py(acceptance checks),AGENTS.mdandCLAUDE.md, the template floors (pymodaq>=5.3.2,pymodaq_utils>=5.3.1,pymodaq_guiandpymodaq_data>=5.3.0), and OS/Python classifiers computed at build time (pymodaq_utils>=5.3.6to build).How: cherry-picked from
main(5cc49fe, c93efcc, 34dcab4). Two conflicts, both resolved with themainversion:python-publish.yml(reusable workflow) and the dependency list ofpyproject.toml. The plugins ofmainthat5.0.xdoes not have (ScannerControl, PLcounter, ...) are not brought over. I did not run the tests locally (no test environment) and nothing was tested with NI hardware: the CI of this PR is the first run of the acceptance checks on the NIDAQmx modules.Generated by Claude Code