Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check the ZIP end record at the end of the returned byte array and compare the decompressed binary payload with the input fixture. The test protects against unused buffer capacity without assuming a platform-specific Deflate size.
On .NET 10.0.400, macOS arm64 produces 905,693 bytes for this fixture, matching the Windows expectation; the existing non-Windows assertion expects 906,121.
Related Issue
Fixes #10040.
Motivation and Context
A valid archive should pass the test when the runtime changes its compressed representation.
Requires Documentation Change
No.
How Has This Been Tested?
Pristine checkout and fresh Release build on macOS arm64, .NET 10.0.400, Python 3.11.15 with the project's pinned scientific dependencies.
ToArray()withGetBuffer()makes the new test fail; restoringToArray()passes again.Types of changes
Checklist:
bug-<issue#>-<description>.