Skip to content

Test ZipBytes archive boundaries instead of compressed size #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkzung wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

Test ZipBytes archive boundaries instead of compressed size #10041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Tests/Compression/CompressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,19 @@ public void ZipBytes()
}

[Test]
public void ZipBytesReturnsByteArrayWithCorrectLength()
public void ZipBytesReturnsOnlyArchiveBytes()
{
const string file = "../../../Data/equity/usa/tick/spy/20131007_trade.zip";
var fileBytes = File.ReadAllBytes(file);
var zippedBytes = QuantConnect.Compression.ZipBytes(fileBytes, "entry");

Assert.AreEqual(OS.IsWindows ? 905693 : 906121, zippedBytes.Length);
// With no ZIP comment, the end-of-central-directory record occupies the last 22 bytes.
CollectionAssert.AreEqual(new byte[] { 0x50, 0x4b, 0x05, 0x06 }, zippedBytes[^22..^18]);
using var input = new MemoryStream(zippedBytes);
using var archive = ZipFile.Read(input);
using var output = new MemoryStream();
archive["entry"].Extract(output);
CollectionAssert.AreEqual(fileBytes, output.ToArray());
}

[Test]
Expand Down