Adding support for MIRIAD calbiration tables - #1695
Open
kartographer wants to merge 12 commits into
Open
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
===========================================
+ Coverage 99.84% 100.00% +0.15%
===========================================
Files 68 69 +1
Lines 23506 23801 +295
===========================================
+ Hits 23470 23801 +331
+ Misses 36 0 -36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kartographer
force-pushed
the
miriad_gains
branch
from
August 18, 2026 02:23
01da6ee to
3377dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new class,
MiriadCal, which supports reading of MIRIAD-based calibration solutions. As part of this, several functions from the UVData-basedMiriadclass have been moved over toaipy_extracts.py(added to theUVclass) to allow for both UVCal and UVData objects from MIRIAD to use the same underlying functions.Motivation and Context
SMA has a large stack of historic calibration tables in MIRIAD, and after pyuvdata added support for writing MeasurementSet-formated gains tables, there was some discussion about getting the read operation to work (both to cross-verify our own internal pipeline as well as to be able to carry forward work that had been previously done in MIRIAD). The existing AIPY interface -- and it's bindings to the
uviointerface -- actually provided much of what was needed for reading this in, most of what was left was some relatively simple plumbing. Note that the ATCA test file actually has calibration solutions for three of the four types supported here, and was used fairly heavily in the testing phase of the code to verify that things were working.(Also, this was this lowest-numbered issue I could close without knowing what an orthoslant is).
Closes #107.
Types of changes
Checklist:
New feature checklist: