Skip to content

Set accepted_at timestamp on ownership transfer acceptance - #1080

Merged
cocomarine merged 1 commit into
mainfrom
record-accepted-at-in-ownership-transfer
Oct 26, 2026
Merged

cocomarine merged 1 commit into
mainfrom
record-accepted-at-in-ownership-transfer

Conversation

@cocomarine

@cocomarine cocomarine commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What's changed?

  • Fixes the bug of not recording accepted_at timestamp upon ownership transfer acceptance.
  • Backfilled the existing records' accepted_at using updated_at for consistency.
    Screenshot 2026-10-26 at 14 32 38

Question

  • There are total 7 records of ownership transfer in prod (all completed). Do we need to back fill their accepted_at fields? Yes

@cla-bot cla-bot Bot added the cla-signed label Oct 26, 2026
@cocomarine
cocomarine marked this pull request as ready for review October 26, 2026 11:38
@github-actions

Copy link
Copy Markdown

Test coverage

94.11% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/40316269063

@raspberrypiherokubot
raspberrypiherokubot temporarily deployed to editor-api-p-record-acc-lcu1tu October 26, 2026 11:40 Inactive
@cocomarine cocomarine changed the title Sets accepted_at timestamp on ownership transfer acceptance Set accepted_at timestamp on ownership transfer acceptance Oct 26, 2026

@mwtrew mwtrew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - it probably is worth backfilling the existing records using updated_at for consistency.

@cocomarine
cocomarine merged commit 7e39436 into main Oct 26, 2026
9 checks passed
@cocomarine
cocomarine deleted the record-accepted-at-in-ownership-transfer branch October 26, 2026 14:49

This branch was previously deployed

1 inactive deployment
editor-api-p-record-acc-lcu1tu — bb8633cb Deployed Oct 26, 2026 by raspberrypiherokubot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants