Skip to content

Set accepted_at timestamp on ownership transfer acceptance #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cocomarine merged 1 commit into from
Oct 26, 2026
Merged

Set accepted_at timestamp on ownership transfer acceptance #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/concepts/ownership_transfer/accept.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def call(ownership_transfer:)
OwnershipTransfer.transaction do
demote_previous_owners(school, ownership_transfer.nominated_user_id)
promote_nominee(school, ownership_transfer.nominated_user_id)
ownership_transfer.update!(status: :completed)
ownership_transfer.update!(status: :completed, accepted_at: Time.current)
end
end

Expand Down
10 changes: 10 additions & 0 deletions spec/concepts/ownership_transfer/accept_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
require 'rails_helper'

RSpec.describe OwnershipTransfer::Accept, type: :unit do
include ActiveSupport::Testing::TimeHelpers

let(:school) { create(:verified_school) }
let(:owner) { create(:owner, school:) }
let(:nominee) { create(:teacher, school:) }
Expand All @@ -23,6 +25,14 @@
expect(ownership_transfer.reload.status).to eq('completed')
end

it 'sets the accepted_at timestamp on the acceptance' do
freeze_time do
described_class.call(ownership_transfer:)

expect(ownership_transfer.reload.accepted_at).to eq(Time.current)
end
end

it 'gives the nominee the owner role' do
described_class.call(ownership_transfer:)

Expand Down
Loading