Repository navigation
fix: name front heated seat params by physical side (#51) - #52
Merged
nanomad merged 1 commit intoOct 25, 2026
Merged
Conversation
Parameters 17 and 18 are the front-left and front-right seats on both left- and right-hand drive cars, not driver/passenger: on a right-hand drive MG S6 EV the iSmart app's front-left (passenger) seat sends 17. Adds HEATED_SEAT_FRONT_LEFT / HEATED_SEAT_FRONT_RIGHT as the primary names and keeps HEATED_SEAT_DRIVER / HEATED_SEAT_PASSENGER as aliases, so existing code keeps working. HeatedSeat and control_heated_seats use the new names; the bytes sent are unchanged (tested).
nanomad
force-pushed
the
fix/heated-seat-physical-sides
branch
from
October 25, 2026 15:01
7a9b9a8 to
e7368b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51. Part of #26.
Parameters 17 and 18 are the physical front-left and front-right seats on both left- and right-hand drive cars, not driver/passenger. On a right-hand drive MG S6 EV (UK account, EU servers), the iSmart app's front-left seat (the passenger's) sends 17.
Changes
RvcParamsId:HEATED_SEAT_FRONT_LEFT = 17andHEATED_SEAT_FRONT_RIGHT = 18are now the main names.HEATED_SEAT_DRIVER/HEATED_SEAT_PASSENGERare kept as aliases of them, so existing code keeps working.HeatedSeatandcontrol_heated_seats: use the new names.tests/test_heated_seat_sides.pychecks the new names, that the old ones still resolve to the same parameters, and thatcontrol_heated_seatsstill sends exactly17, 18, 255as before.ruff (check and format), mypy, pylint and pytest all pass locally on Python 3.13.