[3.0] Gives the other two copies of the header the same wrapper - #9426
Merged
live627 merged 1 commit intoAug 9, 2026
Merged
Conversation
The maintenance page and the profile export build their own copies of the page chrome, and both put content_wrapper on the header itself rather than on a div inside it. That was right when the header was the wrapper, but it stopped being true when the top bar moved in: the flex row is #header .content_wrapper, which needs the inner div, so neither of those two got it. The visible result was a header that did not span the page and stacked its title above its logo instead of putting them at either end. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three places build the page chrome:
index.template.php,Themes/default/MaintenanceTemplate.php, and the XSLT inSources/Tasks/ExportProfileData.php. The last two load the realindex.css, so a selector change in it has to be mirrored in both.When #9373 moved the top bar into the header, the flex row became
#header .content_wrapper— the class moved off#headerand onto adivinside it. The other two copies kept it on#headeritself:so the selector never matched there and neither header got the row. Measured by injecting both structures into a page carrying the real stylesheet, at 1280px:
<div id="header" class="content_wrapper"><header id="header"><div class="content_wrapper">The second row is what the forum's own header measures. The first is a band that stops short of the page edges with the logo stacked under the title.
Both now use the same
<header id="header"><div class="content_wrapper">asindex.template.php. The XSLT fragment was checked for well-formedness after the edit, and both files passphp -l.Found while looking into #9423, but it is a separate defect from the one in #9425 — that one is the CSS leftovers, this one is the markup.
Issues References (Fixes|Related|Closes)
Related #9423
Related #7933