Repository navigation
refactor(autojac): Simplify autojac input utilities - #806
Merged
Merged
Conversation
`as_checked_ordered_set` built the same OrderedSet twice: once to check uniqueness, and once to return it. `create_jac_dict` imported Diagonalize and Init inside the function, although the module already imports `._transform` at the top, so they can be imported there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ValerianRey
added
package: autojac
cc: refactor
github-actions
Bot
changed the title
ValerianRey
marked this pull request as ready for review
October 7, 2026 16:05
ValerianRey
enabled auto-merge (squash)
October 7, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_checked_ordered_setbuiltOrderedSet(tensors)to check uniqueness, then returned a second, identicalOrderedSet(tensors). It now returns the first one. This runs on everybackward,jacandmtl_backwardcall.create_jac_dictimportedDiagonalizeandInitinside the function, although the module already imports._transformat the top. They are now part of that top-level import.There's no circular import:
backwardandjacwork whichever torchjd module is imported first, in fresh interpreters. The autojac, deprecation and import-error tests pass.🤖 Generated with Claude Code