Skip to content

refactor(autojac): Simplify autojac input utilities #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValerianRey merged 3 commits into from
Oct 7, 2026
Merged

refactor(autojac): Simplify autojac input utilities #806

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5368378
Simplify autojac input utilities
ValerianRey Oct 7, 2026
eef2e57
Merge branch 'main' into refactor/autojac-input-utils
ValerianRey Oct 7, 2026
84e78f6
Merge branch 'main' into refactor/autojac-input-utils
ValerianRey Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/torchjd/autojac/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from torch.autograd.graph import Node
from torch.overrides import is_tensor_like

from ._transform import OrderedSet
from ._transform import Diagonalize, Init, OrderedSet


def check_optional_positive_chunk_size(parallel_chunk_size: int | None) -> None:
Expand All @@ -30,7 +30,7 @@ def as_checked_ordered_set(
if len(output) != original_length:
raise ValueError(f"`{variable_name}` should contain unique elements.")

return OrderedSet(tensors)
return output


def check_matching_length(
Expand Down Expand Up @@ -121,9 +121,6 @@ def create_jac_dict(
:param tensor_param_name: The name of the tensor parameter for error messages.
:param jacobian_param_name: The name of the jacobian parameter for error messages.
"""
from torchjd.autojac._transform._diagonalize import Diagonalize
from torchjd.autojac._transform._init import Init

if opt_jacobians is None:
init = Init(tensors)
diag = Diagonalize(tensors)
Expand Down
Loading