Fixed integer overflow with glyph ranges over the signed 16-bit integer limit.#413
Open
Igrium wants to merge 2 commits into
Open
Fixed integer overflow with glyph ranges over the signed 16-bit integer limit.#413Igrium wants to merge 2 commits into
Igrium wants to merge 2 commits into
Conversation
…ers, breaking any icon with an index over the 16-bit integer limit
Author
|
nvm it didn't work. Still trying to figure out why some icons are broken after the update to 1.92 |
Author
|
So it turns out this wasn't the cause of my issue, but it wasn't "correct" anyway. I'll leave it up to you what you wanna do with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a regression where icon fonts with glyph ranges over the signed 16-bit integer limit may not render correctly due to an integer overflow (
ImCharis supposed to be unsigned)Note: needs more testing; I'm not too familiar with the testing process.