Skip to content

Fixed integer overflow with glyph ranges over the signed 16-bit integer limit.#413

Open
Igrium wants to merge 2 commits into
SpaiR:mainfrom
Igrium:main
Open

Fixed integer overflow with glyph ranges over the signed 16-bit integer limit.#413
Igrium wants to merge 2 commits into
SpaiR:mainfrom
Igrium:main

Conversation

@Igrium

@Igrium Igrium commented Jul 22, 2026

Copy link
Copy Markdown

Fixed a regression where icon fonts with glyph ranges over the signed 16-bit integer limit may not render correctly due to an integer overflow (ImChar is supposed to be unsigned)

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Note: needs more testing; I'm not too familiar with the testing process.

@Igrium

Igrium commented Jul 22, 2026

Copy link
Copy Markdown
Author

nvm it didn't work. Still trying to figure out why some icons are broken after the update to 1.92

@Igrium

Igrium commented Jul 22, 2026

Copy link
Copy Markdown
Author

So it turns out this wasn't the cause of my issue, but it wasn't "correct" anyway. I'll leave it up to you what you wanna do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant