Skip to content

Fixed integer overflow with glyph ranges over the signed 16-bit integer limit. #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Igrium wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed integer overflow with glyph ranges over the signed 16-bit integer limit. #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dcbcf0
fixed an issue where glyph ranges were getting parsed as signed integ…
Igrium Jul 22, 2026
b10774b
my dumbass forgot to generate the bindings from the glyph range fix
Igrium Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions imgui-binding/src/generated/java/imgui/ImFontGlyphRangesBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,18 @@ public void addText(final String text) {
}

/**
* Copies all given ranges to resulting ranges
* Copies all given ranges to resulting ranges.
* Short values are treated as unsigned 16-bit integers.
*/
public void addRanges(final short[] ranges) {
for (int i = 0; i < ranges.length; i += 2) {
if (ranges[i] == 0) {
break;
}

for (int k = ranges[i]; k <= ranges[i + 1]; k++) {
final int start = ranges[i] & 0xFFFF;
final int end = ranges[i + 1] & 0xFFFF;
for (int k = start; k <= end; k++) {
addChar((char) k);
}
}
Expand Down
6 changes: 0 additions & 6 deletions imgui-binding/src/generated/java/imgui/extension/texteditor/TextEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,10 @@

import imgui.ImVec2;
import imgui.binding.ImGuiStructDestroyable;





import imgui.extension.texteditor.flag.TextEditorColor;
import imgui.extension.texteditor.flag.TextEditorScroll;
import imgui.internal.ImGuiContext;


public final class TextEditor extends ImGuiStructDestroyable {
public TextEditor() {
super();
Expand Down
5 changes: 0 additions & 5 deletions imgui-binding/src/generated/java/imgui/extension/texteditor/TextEditorLanguage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@

import imgui.binding.ImGuiStruct;






public final class TextEditorLanguage extends ImGuiStruct {
public TextEditorLanguage(final long ptr) {
super(ptr);
Expand Down
7 changes: 5 additions & 2 deletions imgui-binding/src/main/java/imgui/ImFontGlyphRangesBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,18 @@ public void addText(final String text) {
}

/**
* Copies all given ranges to resulting ranges
* Copies all given ranges to resulting ranges.
* Short values are treated as unsigned 16-bit integers.
*/
public void addRanges(final short[] ranges) {
for (int i = 0; i < ranges.length; i += 2) {
if (ranges[i] == 0) {
break;
}

for (int k = ranges[i]; k <= ranges[i + 1]; k++) {
final int start = ranges[i] & 0xFFFF;
final int end = ranges[i + 1] & 0xFFFF;
for (int k = start; k <= end; k++) {
addChar((char) k);
}
}
Expand Down
Loading