Skip to content

perf(smudge): Early return W3DSmudgeManager::render when no smudges are present #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 4 commits into from
Aug 16, 2026
Merged

perf(smudge): Early return W3DSmudgeManager::render when no smudges are present #3140

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60b6af7
perf(smudge): Early return W3DSmudgeManager::render when no smudges p…
stephanmeesters Jul 18, 2026
281bda2
Process review comments
stephanmeesters Aug 14, 2026
89d390a
Adjust condition
stephanmeesters Aug 15, 2026
d95da70
Use correct keyword
stephanmeesters Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,14 @@ void W3DSmudgeManager::render(RenderInfoClass &rinfo)
if (!testHardwareSupport())
return;

// TheSuperHackers @performance stephanmeesters 14/08/2026 Early return when we have no smudge sets
// or if the global smudge set is the only set and contains no smudges.
if (m_usedSmudgeSetList.empty() || (m_usedSmudgeSetList.size() == 1 && m_usedSmudgeSetList.front()->getUsedSmudgeCount() == 0))
{
m_smudgeCountLastFrame = 0;
return;
}

SurfaceClass *backBuffer = DX8Wrapper::_Get_DX8_Back_Buffer();

if (!backBuffer)
Expand Down Expand Up @@ -365,11 +373,8 @@ void W3DSmudgeManager::render(RenderInfoClass &rinfo)
SmudgeSetDeque::iterator setIt=m_usedSmudgeSetList.begin(); //first set that didn't fit into render batch.
Int count = 0;

if (setIt != m_usedSmudgeSetList.end())
{
//there are possibly some smudges to render, so make sure background particles have finished drawing.
SortingRendererClass::Flush(); //draw sorted translucent polys like particles.
}
// make sure background particles have finished drawing.
SortingRendererClass::Flush(); //draw sorted translucent polys like particles.

for(; setIt != m_usedSmudgeSetList.end(); ++setIt)
{
Expand Down
Loading