bugfix(saveload): Transfer the assault transport new member flags - #3148
Draft
bobtista wants to merge 2 commits into
Draft
bugfix(saveload): Transfer the assault transport new member flags#3148bobtista wants to merge 2 commits into
bobtista wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssaultTransportAIUpdatekeeps three parallel arrays for its members, andxferwrites only two:m_newMembermarks a member that boarded after the attack order, and members carrying it are exempt from being ordered out to fight. Losing it means every member loads as an established one and is sent out on the next update.m_newOccupantsAreNewMembersis missing for the same reason, and because it is only set back to TRUE at the end of an update, a passenger already aboard but not yet in the member list is added as established on the frame the save is loaded.Now both travel with the members they describe, from version 2.
Measured by forcing a value at save time, then reading both flags back on load, with the member count as a control:
The member count round trips at 8 in both rows, so the record is written and read either way; version 1 is byte for byte the old behaviour, which is what keeps existing saves readable.
Todo: