Localize departed Workspace lifecycle controls - #767
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirm()with the shared async in-app confirmation dialogWhy
A real Demo walkthrough in Simplified Chinese showed that the entire Departed Workspaces section still rendered in English. Its irreversible Purge files action also opened a native browser confirmation. The lifecycle contract says purge deletes the archived checkout, interactive Session records, and Shell scrollback while retaining the catalog tombstone, retired identities, headless history, Inbox entries, and artifact provenance; the product should disclose that boundary in the selected interface language.
Verification
pnpm vitest run ui/src/pages/WorkspaceListPage.spec.tsx(2 passed)npx tsc --noEmitcd ui && npx tsc -bpnpm test(358 files passed, 1 skipped; 3390 tests passed, 9 skipped)pnpm -F open-alice-ui build:demo