Repository navigation
chore(docs): keep architectural declarations distinct from behavior - #245
Conversation
yordis
commented
Oct 25, 2026
- Architectural declarations need explicit identity and lifecycle rules before labels can be mistaken for behavioral or runtime evidence.
- Deployable and external boundaries must retain their existing meaning while abstract grouping and actor aggregation remain separate decisions.
- Native acceptance must protect exact subjects, visibility and Source isolation before support is considered complete.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview
Roadmap and architecture-resource-coverage now point at this proposal as a specification milestone rather than implying current native support. Reviewed by Cursor Bugbot for commit 63d53e4. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Scope and relationship shape docs/README.md, docs/explanation/architecture-resource-roadmap.md, docs/reference/architecture-resource-coverage.md, docs/reference/system-relationship-contracts.md, docs/reference/system-relationship-acceptance.md |
The documentation links to the proposal and defines its proposed scope, typed relationship shape, and fixture setup. It states that the proposal does not establish implementation. |
Identity and native surfaces docs/reference/system-relationship-contracts.md, docs/reference/system-relationship-acceptance.md |
The proposal specifies identity and lifecycle rules, subject and catalog support, native authoring boundaries, and public-surface acceptance outcomes. |
Admission and resource constraints docs/reference/system-relationship-contracts.md, docs/reference/system-relationship-acceptance.md |
The proposal specifies guarded atomic publication, visibility protections, resource limits, and failure requirements. |
Boundaries and completion evidence docs/reference/system-relationship-contracts.md, docs/reference/system-relationship-acceptance.md |
The documents state deferred interaction and negative scope boundaries, and define evidence required for future acceptance. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Other
Possibly related PRs
- TrogonStack/atlas#233: Establishes subject,
ConnectionId, selector, and catalog-query boundaries referenced by this proposal. - TrogonStack/atlas#242: Documents the deferred relationship boundary that this proposal specifies.
- TrogonStack/atlas#237: Defines source-integration boundaries that this proposal applies to architectural relationships.
Merge Risk: 
Minimal · up to 63d53
-
The documentation-only proposal is mergeable with no identified current-head risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the contract by the moon,
And marks each typed connection in a tune.
“No runtime proof,” the careful pages say,
“Acceptance needs its evidence one day.”
The rabbit hops, then files the links away.
Comment @coderabbitai help to get the list of available commands.