Repository navigation
feat: build IDs from UUIDs and scan native UUID values - #5
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Erik Nilsen <enilsen16@live.com>
Signed-off-by: Erik Nilsen <enilsen16@live.com>
Signed-off-by: Erik Nilsen <enilsen16@live.com>
enilsen16
force-pushed
the
feat/typed-uuid-access
branch
from
October 22, 2026 16:08
658fd8c to
c22f34b
Compare
enilsen16
marked this pull request as ready for review
October 22, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4.
Summary
FromUUID[T](uuid.UUID)builds an ID through the type's Normalize and Validate.id.UUID()returns the bare value as auuid.UUID. Callers that work with UUIDs then don't need to parseBare()themselves. A zero ID fails withErrEmptyValue, and a bare value that is not a UUID fails withErrInvalidUUID.ScanandDecodeSpanneralso acceptuuid.UUIDand[16]byte, for drivers and Spanner columns that carry native UUIDs. A type with full storage rejects them withErrInvalidFormat, because a native UUID has no prefix.Tests
uuid_test.goandExampleFromUUIDcover these cases. CI runs only on PRs tomain. Locally,go test -race,go vetand golangci-lint pass.Need help on this PR? Tag
@codesmith-botwith what you need.