Deserialize a null list field as None instead of raising (#131)#228
Open
CedricConday wants to merge 1 commit into
Open
Deserialize a null list field as None instead of raising (#131)#228CedricConday wants to merge 1 commit into
CedricConday wants to merge 1 commit into
Conversation
The Xero API can return null for an array field (e.g. reject_leave_application responds with "LeaveApplications": None). deserialize_list then tried to iterate over None and raised TypeError: 'NoneType' object is not iterable. Return None when data is None, mirroring how deserialize_model already handles a null payload. Closes XeroAPI#131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
Some Xero API responses return
nullfor a field typed as an array. For examplepayroll_au_api.reject_leave_application(...)responds with:{"Id": "...", "Status": "OK", "LeaveApplications": null}Deserializing this raises:
because
deserialize_listdoes[deserialize(...) for sub_data in data]without guarding againstdata is None.Change
Return
Noneearly whendata is None, faithfully representing the null field. This mirrorsdeserialize_model, which already special-cases aNonepayload.Test
Added
test_deserialize_list_none. It fails onmaster(TypeError) and passes with the fix. Fulltest_api_clientsuite (148 tests) stays green.