Skip to content

Deserialize a null list field as None instead of raising (#131) #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CedricConday wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deserialize a null list field as None instead of raising (#131) #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/test_api_client/test_deserializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@ def test_deserialize_list_key_error():
deserialize_list(data_type, data, model_finder)


def test_deserialize_list_none():
# regression for #131: the Xero API can return null for a list field
# (e.g. "LeaveApplications": None); deserializing must not raise.
result = deserialize_list("list[number]", None, model_finder=None)
assert result is None


# deserialize_int tests
@pytest.mark.parametrize("data,expected", [(n, int(n)) for n in ("1", "-1", 2)])
def test_deserialize_int(data, expected):
Expand Down
2 changes: 2 additions & 0 deletions xero_python/api_client/deserializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ def deserialize_list(data_type, data, model_finder):
:return: deserialized list

"""
if data is None:
return None
try:
sub_data_type = LIST_DATA_TYPE.match(data_type).group(1)
except AttributeError:
Expand Down