Skip to content

fix(timer): always show H:MM once the timer reaches 60 minutes - #62

Merged
Xitee1 merged 1 commit into
mainfrom
fix/time-display-full-hours
Oct 2, 2026
Merged

Xitee1 merged 1 commit into
mainfrom
fix/time-display-full-hours

Conversation

@Xitee1

@Xitee1 Xitee1 commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • A full hour was rendered as a bare 1 with a small "hour" label, which reads like "1 minute" at a glance.
  • From 60 minutes on the dial display now always uses the H:MM form with the hr · min label: 60 minutes shows as 1:00, 120 minutes as 2:00, 90 minutes stays 1:30.
  • Below 60 minutes nothing changes (45 / "minutes").
  • The now-unused time_unit_hour / time_unit_hours strings are removed in both values/ and values-de/.

Only TimeDisplay.kt was affected: the notification uses the notification_minutes_remaining plural and the widget shows plain minutes, so neither had the hour-only form.

Test plan

  • ./gradlew :feature:timer:lintDebug passes
  • Set the dial to exactly 60 min → shows 1:00 / HR · MIN
  • Set the dial to 120 min → shows 2:00 / HR · MIN
  • Set the dial to 90 min → shows 1:30 / HR · MIN
  • Set the dial to 45 min → still shows 45 / MINUTES

🤖 Generated with Claude Code

A full hour was rendered as a bare "1" with a small "hour" label, which
reads like "1 minute" at a glance. From 60 minutes on the display now
always uses the "H:MM" form with the "hr · min" label, so 60 minutes
shows as "1:00" and 120 minutes as "2:00".

The now-unused time_unit_hour / time_unit_hours strings are removed in
both locales.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Xitee1
Xitee1 merged commit 174a645 into main Oct 2, 2026
1 check passed
@Xitee1
Xitee1 deleted the fix/time-display-full-hours branch October 2, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant