fix(timer): always show H:MM once the timer reaches 60 minutes - #62
Merged
Merged
Conversation
A full hour was rendered as a bare "1" with a small "hour" label, which reads like "1 minute" at a glance. From 60 minutes on the display now always uses the "H:MM" form with the "hr · min" label, so 60 minutes shows as "1:00" and 120 minutes as "2:00". The now-unused time_unit_hour / time_unit_hours strings are removed in both locales. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1with a small "hour" label, which reads like "1 minute" at a glance.H:MMform with thehr · minlabel: 60 minutes shows as1:00, 120 minutes as2:00, 90 minutes stays1:30.45/ "minutes").time_unit_hour/time_unit_hoursstrings are removed in bothvalues/andvalues-de/.Only
TimeDisplay.ktwas affected: the notification uses thenotification_minutes_remainingplural and the widget shows plain minutes, so neither had the hour-only form.Test plan
./gradlew :feature:timer:lintDebugpasses1:00/HR · MIN2:00/HR · MIN1:30/HR · MIN45/MINUTES🤖 Generated with Claude Code