Repository navigation
MIT-618: add the table-extraction-pro FastAPI 0.147 GitHub task (batch 8) - #171
Merged
Merged
Conversation
…IT-618 WIP) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
…rds (MIT-618) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
…T-618-batch8 # Conflicts: # tools/eval/github_tasks.py
…T-618) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tools/eval/github_tasks.pygets 1 more verified GitHub task. After merging #169 and #170 the branch holds 9. Zach wants 20, so this is still short. I hit the turn budget and kept the bar where it was.upstream_changegh-table-extraction-bool-formfastapi-0.147-omitted-bool-form-falsebase_commitis the merge's first parent,16908b9.include_metadataanduse_fallbackas optional strings and parse them, applying the default themselves.uv pip install --exclude-newer=... -c requirements/ci-constraints.txt -e .[dev], then thefastapi==0.147.0pin..venvincluded.tests/test_jobs.py. The fix'stests/test_api.pyhas a comment stating the cause ("FastAPI 0.147 reads a missingbool = Form(True)as False"), so it is left out.Base failing output (containerized)
test_job_boolean_form_fields_default_when_omittedand the existingtest_result_formats. The fix changedtest_result_formatsto stop sendinginclude_metadata="true"..scratch/helper that callsrepos.materialize,repos.prepareandrepos.run_testswithcontainer.run, the same stepsagent_eval.py checkruns. Containers ran one at a time, none were left behind, and--on-hostwas never used.Cause-word checks
omitted bool form fields as false,omitted bool form field as falseomitted boolean form fields as false,omitted boolean form field as falsehtml checkbox,unchecked checkbox,checkbox semantics0.147boolform field, with its new rule: an omitted field is read as False, the "unchecked HTML checkboxes" of the release notes.bool form fieldnames the object but not the change. A symptom-only fix says it ("make the bool form field Optional"), and word-start matching also catches "bool form fields".checkboxanduncheckedwere dropped for the same reason.boolean form field: it hits the laid-over test names.default: a fix that only treats the symptom says it.mentionsagainst:tests/test_jobs.pyat the fix sha;include_metadata,metadata), in both directions;extract,extract_batch,create_job,parse_form_bool), the failing tests and the traceback's last call (get);table_extraction/api/main.pyandjobs.py, plusREADME.mdandtests/test_api.py(git show 16908b9:<path>from the repo cache).defaulthits every source, as expected.0.147is the only version word. The other seven are non-version words.0.147. It is added to the expected set intest_the_cause_words_grader_v2_skips_are_exactly_the_versions.Merge
I merged
origin/feature/eval-setuptwice, after #169 and after #170. TheTASKSconflict kept both sides. The version set merged cleanly:2.0was already in it.Rejected candidates
This batch:
requirements.txtcomment states it too.streamingno longer streams mstar-project/mstar#713 (fastapi 0.147): the repo is 690 MB.**extra): the fixes change no test.FileResponsewatches for disconnects): the new test's docstring states the cause and the fix.TemplateResponse): no license, no test change, and the change came before the cutoff._Lifespannever closes its anyio streams; withfilterwarnings = erroran unrelated test fails withResourceWarning: Unclosed <MemoryObjectReceiveStream>schemathesis/schemathesis#5085 (anyio streams in its own lifespan): a schemathesis change, not an upstream one; 139 MB.BlockingPortaldeprecation): the fix is only a pytest config change.click.STRINGalways coerces adefault_maplist.--no-verifynot disabling SSL verification korewayume/httpx#1 (click 8.5flag_valuefor--no-verify): the fix changes no test.abi_tagkarellen/wheel-axle#42 (setuptools 84.2 read-onlyabi_tag): the new tests' docstrings state the cause, and theAttributeErrornames it.From the brief and PRs #164, #165, #167 and #168: not re-checked.
Unfinished: none. The uncommitted change in the earlier run was a comment on this task (its measured size and the constraints note), not a second task. It is committed with the task.
Why
Ticket: MIT-618 (batch 8), the GitHub-task eval. These are real post-cutoff tasks for the arms run.
How it was tested
server/tests/test_eval_grader.pyandserver/tests/test_eval_repos.pypass.make checkpasses after both merges oforigin/feature/eval-setup(1532 passed).Learned
is:pr is:merged, a quoted release string) finds far more code fixes than the closed-issue search withlinked:pr. For fastapi 0.147 it found about 20 fix PRs where issue search found 4. Many of them never had an issue.nullversus omitted (0.151), header names in errors (0.152) and the removal of**extra(0.145, 0.155). Downstream fixes for 0.148 and later are still rare.git --git-dir <cache>is refused in worktree shells. Read cached repos through a.scratch/helper run withpython3 -I.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y