Skip to content

feat(observability): identify selected request resource revisions - #11

Draft
afourniernv wants to merge 1 commit into
mainfrom
feat/5396-request-revisions/afourniernv
Draft

afourniernv wants to merge 1 commit into
mainfrom
feat/5396-request-revisions/afourniernv

Conversation

@afourniernv

@afourniernv afourniernv commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Identify the policy, endpoint and credential snapshot actually selected by an inspected request. This is independently based on main and #5214, without requiring the middleware or credential-observation follow-ups.

Related Issue

Closes NVIDIA#5396. Tracking: NVIDIA#5210.

Changes

  • Retain the first selections at their actual use sites rather than looking up newer configuration when logging.
  • Enrich original OCSF records only with selections known at their emission time; later lookups do not rewrite earlier records.
  • Preserve full-width generations/revisions as decimal strings. Distinguish the complete credential-environment revision from its installation ID, including repairs at the same revision.
  • Use existing OCSF extension fields and add no routine audit records or public API.

Integration note: this and MCP #12 overlap at JSON-RPC scope creation. When combining them, capture policy generation and endpoint at the earlier scope creation, before body inspection. The combined build was tested with that resolution.

Release Notes

Request traces and security records identify the configuration selected for that request, not necessarily the configuration current when an operator investigates it. A selected credential snapshot does not establish injection or delivery.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • Independent network Nextest suite: 1,728 passed; seven skipped. All five focused snapshot tests passed.

  • The new regression completes request A, reloads policy, confirms the idle connection closes, reconnects for B, and checks both generations on request spans and correlated OCSF records.

  • Same-surviving-connection coverage depends on unmerged #5361; this PR does not implement or claim connection repinning.

  • Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.

  • A fresh two-turn Hermes/Relay run verified changed loaded policy hash/generation across reload and reconnect, with matching request/root/OCSF identities. It does not claim surviving-connection or changed-enforcement coverage. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.

  • The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): crate and published OCSF guidance updated; subsystem boundaries unchanged.

@afourniernv
afourniernv changed the base branch from feat/5395-credential-correlation/afourniernv to codex/relay-state-01-correlation-primitives November 10, 2026 23:04
@afourniernv
afourniernv changed the base branch from codex/relay-state-01-correlation-primitives to feat/5395-credential-correlation/afourniernv November 13, 2026 00:37
@afourniernv
afourniernv force-pushed the feat/5395-credential-correlation/afourniernv branch from c0f634b to 8bc8f32 Compare November 17, 2026 17:27
@afourniernv
afourniernv force-pushed the feat/5396-request-revisions/afourniernv branch from 720e766 to 486e90e Compare November 17, 2026 17:27
@afourniernv afourniernv changed the title feat(observability): identify policy and provider revisions used by a request feat(observability): identify selected request resource snapshots Nov 17, 2026
Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv force-pushed the feat/5395-credential-correlation/afourniernv branch from 8bc8f32 to 7b3ab05 Compare November 18, 2026 00:48
@afourniernv
afourniernv force-pushed the feat/5396-request-revisions/afourniernv branch from 486e90e to 4cdb38a Compare November 18, 2026 00:48
@afourniernv afourniernv changed the title feat(observability): identify selected request resource snapshots feat(observability): identify selected request resource revisions Nov 18, 2026
@afourniernv
afourniernv changed the base branch from feat/5395-credential-correlation/afourniernv to main November 18, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(observability): identify policy and provider revisions used by a request

1 participant