Skip to content

feat(observability): trace bounded MCP inspection outcomes - #12

Draft
afourniernv wants to merge 1 commit into
mainfrom
feat/5397-mcp-correlation/afourniernv
Draft

afourniernv wants to merge 1 commit into
mainfrom
feat/5397-mcp-correlation/afourniernv

Conversation

@afourniernv

@afourniernv afourniernv commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Trace actual JSON-RPC/MCP inspection passes under the inspected HTTP request. This is independently based on main and #5214, not on resource revision tracing.

Related Issue

Closes NVIDIA#5397. Tracking: NVIDIA#5210.

Changes

  • Add an inspection child span with bounded protocol/revision, shape, result and counts from at most 64 calls, plus a truncation flag.
  • Establish request attribution before standalone body inspection while preserving parsing, framing and rejection behavior.
  • Omit method/tool names, arguments, payloads and response content.
  • Keep inspection acceptance separate from policy approval and remote execution. Preserve existing 400/403 responses and per-control audit records.

No new external Rust API, protobuf field, configuration or enforcement capability.

Integration note: when combining with revisions #11, retain policy-generation and endpoint capture at this change's earlier JSON-RPC scope creation, before body inspection. The combined build was tested with that resolution.

Release Notes

An inspected request can show which JSON-RPC/MCP inspection passes ran and whether they accepted or rejected its shape. An accepted inspection can still be denied by policy; it does not prove a tool executed.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • Independent network Nextest suite: 1,725 passed; seven skipped.

  • Tests check bounded batch metadata, privacy, correct request parentage, malformed-input 400, valid-inspection/policy-denial 403, and correlation without exported spans.

  • Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.

  • Fresh Hermes/Relay execution verified accepted MCP operations and an inspected-but-policy-denied rotation, with the target rotation counter unchanged. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.

  • The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): crate and published inspection-trace guidance updated; subsystem boundaries unchanged.

@afourniernv
afourniernv force-pushed the feat/5396-request-revisions/afourniernv branch from 720e766 to 486e90e Compare November 17, 2026 17:27
@afourniernv
afourniernv force-pushed the feat/5397-mcp-correlation/afourniernv branch from d0f6e48 to 745d8e1 Compare November 17, 2026 17:27
@afourniernv afourniernv changed the title feat(observability): correlate MCP inspection outcomes with HTTP requests feat(observability): trace bounded MCP inspection outcomes Nov 17, 2026
Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv force-pushed the feat/5397-mcp-correlation/afourniernv branch from 745d8e1 to 185d4d6 Compare November 18, 2026 00:48
@afourniernv
afourniernv force-pushed the feat/5396-request-revisions/afourniernv branch from 486e90e to 4cdb38a Compare November 18, 2026 00:48
@afourniernv
afourniernv changed the base branch from feat/5396-request-revisions/afourniernv to main November 18, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(observability): correlate MCP inspection outcomes with HTTP requests

1 participant