Repository navigation
fix(ui): stop the credentials group overlapping network endpoints - #139
Open
Gkrumbach07 wants to merge 1 commit into
Open
Gkrumbach07 wants to merge 1 commit into
Gkrumbach07 wants to merge 1 commit into
Conversation
Each credential row in the Create provider profile modal was wrapped in its own one-item PatternFly Stack. The Stack layout sets height: 100%, and inside the Form's CSS grid the form group control is stretched to a definite height, so the Stack filled the whole control (the blank gap under the row) and pushed the "Add credential" link and its helper text out of the group, over the "Network endpoints" label. Render each credential row as a bare Grid, as the endpoint rows already are. Fixes ai-openshell#132 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
Root cause
In the Create provider profile modal, each credential row was wrapped in its own one-item PatternFly
Stack. The Stack layout setsheight: 100%. TheFormis a CSS grid, so the grid row of the Credentials group is first sized from its content (row + "Add credential" + helper text, 88px for the control). The form group control is then stretched to that definite height, and the Stack's100%resolves against it. The Stack takes the whole 88px, which is the blank gap under the row. The "Add credential" link and the helper text that follow it overflow the group by about 50px and land on the "Network endpoints" label.The endpoint rows are bare
Grids, so the Network endpoints group was never affected.Fix
Each credential row is now a bare
Grid, like the endpoint rows. The one-itemStack/StackItemwrapper added nothing, and thedata-testids are unchanged.Verification
make dev-mockat 1280×1000, Create profile → Add credential: the overlap from the issue screenshot appears.npm run lint,format:check,make typecheck, andCreateProfileModal.spec.tsx(6) plusProfilesPanel.spec.tsx(15) all pass. No Go code changed.Screenshots
Create profile → Add credential, at 1280×1000 (
make dev-mock).🤖 Generated with Claude Code