Repository navigation
fix(deps): zip 9 へ移行し cargo group 更新を取り込む (#525) - #526
Merged
Merged
Conversation
Supersedes Dependabot #523: zip 8 -> 9, serde_json 1.0.154, tokio 1.53.3, toml_edit 0.25.17, sha2 0.11.1. zip 9 returns Result from ZipFile::name(); propagate failures with anyhow context instead of panicking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zipを 8 → 9 に移行し、Dependabot chore(deps): bump the cargo group with 5 updates #523 の cargo group 更新(serde_json 1.0.154 / tokio 1.53.3 / toml_edit 0.25.17 / sha2 0.11.1)を同時に取り込むZipFile::name()がResult<Cow<str>, ZipError>を返すようになったため、src/reference/fetcher.rsのextract_zip_to/detect_top_level_prefixでanyhowの context 付きエラーとして伝播(panic しない)Supersedes #523
Closes #525
Notes / Assumptions
Cargo.lockの zip は 9.0.5(9.x 最新互換、chore(deps): bump the cargo group with 5 updates #523 の 9.0.3 以上)name()のエラー経路は、非 UTF-8 名が必ず 0x80 以上のバイトを含み CP437 変換が失敗しないため実質到達不能。失敗注入テストは作れないため、既存の展開テスト(prefix 除去 /..拒否)で回帰を担保Verification (gwtd verify.run PASS: vrr-938ccd10a60148c8b1eeaefc10728e49)
cargo fmt --all -- --check✅cargo clippy --workspace --all-targets --all-features -- -D warnings✅RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items✅TMPDIR=/tmp cargo test --workspace --all-features -- --test-threads=1✅(606 unit + integration 全 pass)cargo test --all-targets -- --test-threads=1も全 pass)cargo run -- skills lint --severity error✅User Verification Result: n/a (autonomous)
Agent Visual Check: n/a (no UI surface)
🤖 Generated with Claude Code
Agent: ミク (Claude Code)