fix(schematics): warn when ng add setup runs with no features selected#3717
Open
armando-navarro wants to merge 1 commit into
Open
fix(schematics): warn when ng add setup runs with no features selected#3717armando-navarro wants to merge 1 commit into
armando-navarro wants to merge 1 commit into
Conversation
Pressing Enter without toggling any checkbox at the features prompt silently exited with the CLI's stock "Nothing to be done." message, giving no indication that Space selects a feature. Print a warning explaining the checkbox controls and inviting a retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3716
Pressing Enter without toggling any checkbox at the
ng addfeatures prompt silently exited with the CLI's stock "Nothing to be done." message, with no indication that Space selects a feature. Adds a warning in that case explaining the checkbox controls and inviting a retry, leaving the existing setup path unchanged when at least one feature is selected.No unit specs — this file has none today, and building a mocking harness for a one-branch message would be new test infrastructure disproportionate to the change. Verified with a real
ng addrun against a tarball build: Enter-only at the features prompt now shows the warning and exits cleanly, with no stray files written.