Skip to content

fix(schematics): warn when ng add setup runs with no features selected #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armando-navarro wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(schematics): warn when ng add setup runs with no features selected #3717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/schematics/setup/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,14 @@ export const ngAddSetupProject = (

const features = await featuresPrompt();

if (features.length > 0) {
if (features.length === 0) {
context.logger.warn(
'No features were selected, so there is nothing to set up. ' +
'At the "What features would you like to setup?" prompt, use the arrow keys to move, ' +
'press Space to select each feature you want, then Enter to confirm. ' +
'Re-run ng add @angular/fire to try again.'
);
} else {

const firebaseTools = await getFirebaseTools();

Expand Down
Loading