Skip to content

refactor(server): remove plugin readiness from plugin.list - #64524

Merged
rekram1-node merged 1 commit into
devfrom
revert-plugin-ready
Nov 17, 2026
Merged

rekram1-node merged 1 commit into
devfrom
revert-plugin-ready

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Issue for this PR

Reverts #64029.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Removes ready from plugin.list and the extra plugin.updated events sent when it flipped. Nothing reads it: the TUI, desktop and mobile apps refresh on *.updated, and a Session already waits for plugins before each model call, so opencode run doesn't need it either. It hasn't shipped in a release, so no SDK user depends on it.

How did you verify your code works?

  • Clean revert of the merged commit; bun run generate in packages/protocol and packages/client leaves no diff.
  • bun typecheck passes in core, server, protocol and client; core plugin tests (635) and server tests (131) pass.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Added by the opencode bot (AI-generated).

Related: #64464

Public API: removes the optional ready field from plugin.list (HTTP, client, plugin ctx) and the plugin.updated events sent when it flipped; not in any release

@rekram1-node rekram1-node changed the title revert: report plugin readiness on plugin.list refactor(server): remove plugin readiness from plugin.list Nov 17, 2026
@rekram1-node
rekram1-node enabled auto-merge (squash) November 17, 2026 21:24

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It undoes #64029 exactly: the diff matches the reverse of 133f24a line for line, and I found no caller of plugin.list that reads ready, whether in the CLI, TUI, app, desktop, plugin adapter or gui-plugins. Running tsc on core, server, protocol, client and app gives no errors. Core plugin tests (635) and server tests (131) pass.

Public API: it removes the optional ready field from the plugin.list response. That covers the HTTP API, the OpenAPI spec, the @opencode/client types and plugin ctx.plugin.list(). plugin.updated also no longer fires when readiness flips. 133f24a isn't in v2.3.0 and there's been no release since, so no released client or plugin depends on it, and old clients already treated the field as optional.

One leftover, not blocking: the story mock in packages/app/src/components-lab/dialog-story-runtime.tsx still returns ready: true for /api/plugin. It's harmless and can be removed whenever.

Related: #64464

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing new to look at: the new head fb1cbfa0e is the commit my previous review already checked, and none of its threads were open. It's still a clean revert of #64029. Nothing reads ready, tsc gives no errors for core, server, protocol, client and app, and the core plugin and server tests pass.

Public API: it removes the optional ready field from the plugin.list response (HTTP API, OpenAPI spec, @opencode/client types, plugin ctx.plugin.list()). plugin.updated also no longer fires when readiness flips. The field was never in a release, so nothing released depends on it.

@rekram1-node
rekram1-node merged commit 7bec1e6 into dev Nov 17, 2026
15 checks passed
@rekram1-node
rekram1-node deleted the revert-plugin-ready branch November 17, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant