Repository navigation
refactor(server): remove plugin readiness from plugin.list - #64524
Conversation
This reverts commit 133f24a.
774251a to
fb1cbfa
Compare
There was a problem hiding this comment.
This looks good to me. It undoes #64029 exactly: the diff matches the reverse of 133f24a line for line, and I found no caller of plugin.list that reads ready, whether in the CLI, TUI, app, desktop, plugin adapter or gui-plugins. Running tsc on core, server, protocol, client and app gives no errors. Core plugin tests (635) and server tests (131) pass.
Public API: it removes the optional ready field from the plugin.list response. That covers the HTTP API, the OpenAPI spec, the @opencode/client types and plugin ctx.plugin.list(). plugin.updated also no longer fires when readiness flips. 133f24a isn't in v2.3.0 and there's been no release since, so no released client or plugin depends on it, and old clients already treated the field as optional.
One leftover, not blocking: the story mock in packages/app/src/components-lab/dialog-story-runtime.tsx still returns ready: true for /api/plugin. It's harmless and can be removed whenever.
Related: #64464
There was a problem hiding this comment.
Nothing new to look at: the new head fb1cbfa0e is the commit my previous review already checked, and none of its threads were open. It's still a clean revert of #64029. Nothing reads ready, tsc gives no errors for core, server, protocol, client and app, and the core plugin and server tests pass.
Public API: it removes the optional ready field from the plugin.list response (HTTP API, OpenAPI spec, @opencode/client types, plugin ctx.plugin.list()). plugin.updated also no longer fires when readiness flips. The field was never in a release, so nothing released depends on it.
Issue for this PR
Reverts #64029.
Type of change
What does this PR do?
Removes
readyfromplugin.listand the extraplugin.updatedevents sent when it flipped. Nothing reads it: the TUI, desktop and mobile apps refresh on*.updated, and a Session already waits for plugins before each model call, soopencode rundoesn't need it either. It hasn't shipped in a release, so no SDK user depends on it.How did you verify your code works?
bun run generateinpackages/protocolandpackages/clientleaves no diff.bun typecheckpasses in core, server, protocol and client; core plugin tests (635) and server tests (131) pass.Checklist
Added by the opencode bot (AI-generated).
Related: #64464
Public API: removes the optional
readyfield from plugin.list (HTTP, client, plugin ctx) and the plugin.updated events sent when it flipped; not in any release