Repository navigation
GH-53818: [C++][FlightRPC][ODBC] Fix Windows ODBC Installer Registering Empty Driver and Setup Paths - #53819
Merged
Conversation
- Add CI verification step as well
|
|
github-actions
Bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
marked this pull request as ready for review
October 14, 2026 22:39
alinaliBQ
requested review from
assignUser,
jonkeane,
kou,
lidavidm and
raulcd
as code owners
October 14, 2026 22:39
kou
approved these changes
Oct 16, 2026
kou
left a comment
kou
left a comment
Member
There was a problem hiding this comment.
+1
I don't think that this is a "Critical Fix" because this is a packaging bug. It's not included in our "Critical Fix" definitions ((a), (b) and (c)). But we may include this to 26.0.1 if we release 26.0.1. @raulcd may have an opinion for this.
Collaborator
Author
|
@kou Understood, thank you for merging the PR and helping to edit the PR description! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#53818
What changes are included in this PR?
DriverandSetupvalues. Both values should point to the actual installed driver path.Are these changes tested?
Are there any user-facing changes?
Yes. This fixes a packaging bug of the Windows ODBC installer.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: