[DaanHoogland]

Depends on #14560

Description

Removes never-used parameters from non-framework methods:

• StorageManager.cleanupStorage(boolean recurring) → cleanupStorage() (callers: StorageManagerImpl, GarbageCollectingStoragePoolAllocator)
• cleanupSecondaryStorage(boolean recurring) → cleanupSecondaryStorage()
• removes the stubs sendToPool(long poolId, Command) and sendToPool(long poolId, Commands), which ignored both parameters, returned null and had no callers (every caller uses the StoragePool overloads)

The remaining unused parameters belong to framework contracts (configure, ClusterManagerListener) and stay.

Part of #12316

Types of changes

• Cleanup (Code refactoring and cleanup, that may add test cases)

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (585204c) to head (15ec773).

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	4 Missing ⚠️
...locator/GarbageCollectingStoragePoolAllocator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##             ghi12316-storage-rawtypes   #14561      +/-   ##
===============================================================
- Coverage                        20.78%   20.78%   -0.01%     
- Complexity                       21929    21931       +2     
===============================================================
  Files                             6496     6496              
  Lines                           591486   591480       -6     
  Branches                         72566    72566              
===============================================================
- Hits                            122956   122946      -10     
- Misses                          455185   455194       +9     
+ Partials                         13345    13340       -5     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.09% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.89%
Branch coverage	20.23%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run