[DaanHoogland]

Depends on #14561

Description

Handles the remaining trivial warnings in StorageManagerImpl and the storage commands:

• parameterised logging instead of String.format and string concatenation
• isEmpty() and CollectionUtils instead of size() > 0, and simplified boolean and redundant-initialiser code
• removes redundant logger.isDebugEnabled() guards around parameterised calls. Guards that protect eagerly computed toHumanReadableSize() arguments stay.
• drops required = false (the default) and reformats long @Parameter annotations

The SearchCriteria.addAnd deprecations follow in #14564. The Config deprecation warnings are left to #10752 / #14467.

Part of #12316

Types of changes

• Cleanup (Code refactoring and cleanup, that may add test cases)

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 19.46903% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (15ec773) to head (5a9c055).

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	18.91%	89 Missing and 1 partial ⚠️
...rc/main/java/com/cloud/storage/StorageManager.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##             ghi12316-storage-unused-params   #14562       +/-   ##
=====================================================================
+ Coverage                              3.88%   20.78%   +16.90%     
- Complexity                                0    21927    +21927     
=====================================================================
  Files                                   493     6496     +6003     
  Lines                                 42571   591459   +548888     
  Branches                               8069    72547    +64478     
=====================================================================
+ Hits                                   1653   122929   +121276     
- Misses                                40687   455196   +414509     
- Partials                                231    13334    +13103     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.09% <19.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[sonarqubecloud]

Quality Gate failed

Failed conditions
6.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.89%
Branch coverage	20.23%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run