[DaanHoogland]

Depends on #14562

Description

Replaces the deprecated SearchCriteria.addAnd() calls in StorageManagerImpl (10 warnings → 0) with SearchBuilders declared once in configure(), like the existing LocalStorageSearch:

• createCapacityEntry: PoolCapacitySearch (hostOrPoolId, dataCenterId, capacityType)
• getStoragePoolUsedStatsInternal: PoolUsedStatsSearch. Optional zone/pod/cluster/id filters are only set when given; unset conditions are dropped from the WHERE clause, as before. The criteria are now only built in the branch that actually searches: when a single poolId is given, the old code built them and then used findById anyway.
• getSecondaryStorageUsedStats: removes a SearchCriteria that was built but never used.

After this PR and the ones it depends on, the only javac warnings left in these files are the 4 Config deprecations, which #14467 handles.

Fixes: #12316

Types of changes

• Cleanup (Code refactoring and cleanup, that may add test cases)

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (5a9c055) to head (8c7dab4).

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	26 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##             ghi12316-storage-trivial-warnings   #14564   +/-   ##
====================================================================
  Coverage                                20.78%   20.78%           
- Complexity                               21927    21932    +5     
====================================================================
  Files                                     6496     6496           
  Lines                                   591459   591466    +7     
  Branches                                 72547    72545    -2     
====================================================================
+ Hits                                    122929   122954   +25     
+ Misses                                  455196   455169   -27     
- Partials                                 13334    13343    +9     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.09% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.89%
Branch coverage	20.23%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run